Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additionally extend github/typescript ESLint config #595

Closed
wants to merge 1 commit into from

Conversation

namoscato
Copy link
Contributor

@namoscato namoscato commented Sep 10, 2022

  • Additionally extend eslint-plugin-github's typescript ruleset (which extends @typescript-eslint/recommended and notably disables additional core ESLint rules that are already checked by the TypeScript compiler such as no-shadow)
  • Remove some now unnecessary rule overrides
  • Reformat .eslintrc.json per Prettier configuration (feel free to ignore whitespace on review)

@namoscato namoscato requested a review from a team as a code owner September 10, 2022 13:28
myyk added a commit to myyk/git-democracy that referenced this pull request Nov 21, 2022
myyk added a commit to myyk/git-democracy that referenced this pull request Nov 21, 2022
* clean up eslint config

* refresh .eslintrc.json from template

* pull changes from actions/typescript-action#595

* remove i18n-text/no-en

* add dist
@ncalteen
Copy link
Collaborator

👋🏻 Hello! Apologies for the delay on this issue. I am going through this repository and making some large updates. This will be resolved by #732

@ncalteen ncalteen self-assigned this Aug 24, 2023
@ncalteen ncalteen mentioned this pull request Aug 24, 2023
@ncalteen
Copy link
Collaborator

I've merged this change into #732 so that your contributions will be tracked :) I am going to go ahead and close this PR while we track the remaining work in the larger one. Thank you for the contributions!

@ncalteen ncalteen closed this Aug 24, 2023
@namoscato namoscato deleted the namoscato/eslint branch August 24, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants